Skip to content

Update JES example-link to blog#27

Open
ppcano wants to merge 2 commits into
keptn-sandbox:mainfrom
ppcano:transfer-tutorial1
Open

Update JES example-link to blog#27
ppcano wants to merge 2 commits into
keptn-sandbox:mainfrom
ppcano:transfer-tutorial1

Conversation

@ppcano

@ppcano ppcano commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

The first tutorial has been published at https://k6.io/blog/performance-testing-in-keptn-using-k6/.

Cross-linking to have a single source of truth and avoid content duplication.

Signed-off-by: Pepe Cano 825430+ppcano@users.noreply.github.com

Signed-off-by: Pepe Cano <825430+ppcano@users.noreply.github.com>
@ppcano ppcano requested a review from jainammm as a code owner November 8, 2022 06:06
Comment thread docs/k6-jes-example/README.md Outdated
## Demo Link

- The Demo Link to this tutorial can be found here - [YouTube](https://www.youtube.com/watch?v=MtjbvnDbhP8)
On the k6 blog, check out the [tutorial to run k6 tests in Keptn](https://k6.io/blog/performance-testing-in-keptn-using-k6/).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this content from the Readme? because the files required will be appropriately linked, which are not in the blog... we can reference with a link here only I guess

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we preserve this Readme file, I think we should link to the tutorial.

I changed the content of the sentence 52d5146 - perhaps, that one fits better. Otherwise, I'll remove the entire paragraph. Just let me know.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I feel that if someone is already in the repo it'll be better if they follow the Readme only because they have links to the files needed directly
so we can keep the Readme... and link the tutorial in a separate paragraph itself in the main project Readme... Also, we can keep the references to previous tutorials in the same place pointing to Readme and not the blog post... only because the files that need to be added are already here users can directly look at them with the hyperlink provided in the readme (which are not there in blog)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jainammm - I don't fully catch your proposal. Perhaps, it is better if you continue this PR or create a new one that supersedes it.

Signed-off-by: Pepe Cano <825430+ppcano@users.noreply.github.com>
@ppcano ppcano force-pushed the transfer-tutorial1 branch from 20fcafe to 52d5146 Compare November 8, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants